Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removal of added GNU_SOURCE before search #2091

Closed
ingwinlu opened this issue Jun 17, 2018 · 2 comments
Closed

removal of added GNU_SOURCE before search #2091

ingwinlu opened this issue Jun 17, 2018 · 2 comments
Labels

Comments

@ingwinlu
Copy link
Contributor

Should https://github.com/ElektraInitiative/libelektra/blob/master/src/include/CMakeLists.txt#L11
be removed?

if you add a definition to list that is not used during compilation you will get segfaults. It probably only works on systems that default export anything.

@markus2330
Copy link
Contributor

I think @KurtMi added this for benchmarks.

Yes, we could move this to a bit less public place. (Where it is needed, i.e., in the benchmarks.)

@ingwinlu
Copy link
Contributor Author

Ah I see his approach now. It is fine as it is working correctly in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants