-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clang-format version #4518
Comments
Clang format 14 is not yet on Debian Sid, which we use in the CI for the formatting check…Should we switch to a different container?
|
At least the online package search says that the current And there is also a separate package for version 15: https://packages.debian.org/sid/clang-format-15
Might be a good idea to use a separate container for formatting and similar checks that contributors may want to run locally (spelling, release notes, clang-tidy #4517, etc.). Keeping that container small would make that much easier. The Alpine Linux Package for clang-format is also already on version 15.0.2 (released this week). I think a small alpine container would be ideal here. |
Switching clang-format is a task shortly before a release (to minimize necessary rebasing of PRs), so let us have a look at the situation when it is time. |
Could also be done right after merging |
It cannot really be forgotten totally. I don't think we need to create issues as long as there is no depreciation warning or it is getting difficult to install. If we skip some releases, we have less effort. |
Honestly please answer this question: "WHY do you hate issues so much?" Having an issue clearly signals there is something to be done. Especially, in a case like this, where it can't be solved immediately. Waiting until there is a problem is not even a good solution here, because then the change would be urgent and can't just be done when it is convenient. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Updating clang is done regularly by @mpranj before the releases, no issues are needed for this. Release notes are our way to communicate that such a change happened. |
clang-format version 15 has been released. We still use version 13 (see
scripts/dev/reformat-c
). At some point we should update. This will probably involve a bigger reformatting PR.The text was updated successfully, but these errors were encountered: