Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restyle checker problems #4687

Closed
markus2330 opened this issue Nov 17, 2022 · 4 comments
Closed

restyle checker problems #4687

markus2330 opened this issue Nov 17, 2022 · 4 comments
Labels

Comments

@markus2330
Copy link
Contributor

markus2330 commented Nov 17, 2022

It appears to me that the restyle check always fails because of the underscore in the filename. When escaping the underscore \_ it complained it shouldn't have the escaping backslash - now with the escaping-backslash removed (which is wrong i think) it says it should be something totally wrong (Extend check*doc.sh to work for contrib and tutorials *(@Joni1993)\_)

Originally posted by @joni1993 in #4634 (comment)

@markus2330
Copy link
Contributor Author

Yeah, the restyler's suggestions are sometimes wrong, feel free to report this problem to prettier. I can reproduce the problem here: https://prettier.io/playground

- Extend check_doc.sh to work for contrib and tutorials _(@Joni1993)_
- Extend check*doc.sh to work for contrib and tutorials *(@Joni1993)\_

Is obviously not a good suggestion.

@kodebach
Copy link
Member

Is obviously not a good suggestion.

IMO this is a fine suggestion. I would prefer the following, but I assume that's an issue with prettier's parser. It probably thinks the first two _ belong together and form an emphasised section.

-- Extend check_doc.sh to work for contrib and tutorials _(@Joni1993)_
+- Extend check\_doc.sh to work for contrib and tutorials *(@Joni1993)*

However, the issue is that this suggestion also happens:

-- Extend check\_doc.sh to work for contrib and tutorials _(@Joni1993)_
+- Extend check_doc.sh to work for contrib and tutorials _(@Joni1993)_

I don't see any reason why this should ever be suggested (why remove the escape character?), but it definitely is a problem because it causes a suggestion cycle.

Copy link

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot added the stale label Nov 18, 2023
Copy link

github-actions bot commented Dec 3, 2023

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue.
Thank you for your contributions 💖

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants