Tooltip, Dropdown, Popover: support tabindex attribute #15167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit bfb973e |
aphofstede
reviewed
Apr 23, 2019
| @@ -113,6 +117,9 @@ export default { | |||
| on(reference, 'mouseleave', this.handleMouseLeave); | |||
| on(popper, 'mouseleave', this.handleMouseLeave); | |||
| } else if (this.trigger === 'focus') { | |||
| if (this.tabindex < 0) { | |||
| console.warn('[Element Warn][Popover]a negative taindex means that the element cannot be focused by tab key'); | |||
FAKER-A
pushed a commit
to FAKER-A/element
that referenced
this pull request
May 7, 2019
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11875
Closes #11519
Closes #11512