Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow LSTM speed relative to theano. #182

Closed
c0nn3r opened this issue Mar 29, 2016 · 6 comments
Closed

Slow LSTM speed relative to theano. #182

c0nn3r opened this issue Mar 29, 2016 · 6 comments

Comments

@c0nn3r
Copy link

c0nn3r commented Mar 29, 2016

Recently, a benchmark was made comparing the rnn package to Theano, and found Theano to be much much faster (the benchmark can be found here). This is concerning. It's currently unknown if other implementation of RNNs in torch are faster (torch-rnn might be), but it seems some improvement to speed could be made. I'm hope to revisit this problem when I have less deadlines to deal with, but just wanted to hear other's thoughts. Thanks.

@uralik
Copy link

uralik commented Mar 29, 2016

as I got, in this benchmark they did not use nngraph. (at least in the source code) With nngraph FastLSTM is faster.

@c0nn3r
Copy link
Author

c0nn3r commented Mar 29, 2016

How do you set the variable? Do you do it before you build rnn? I will submit a pull request to make the change.

@uralik
Copy link

uralik commented Mar 29, 2016

Should be something like in this simple example, so you just set the flag.

@nicholas-leonard
Copy link
Member

@Torkoal Thanks for updating that benchmark :)

@nicholas-leonard
Copy link
Member

@Torkoal Also feel free to try to improve the speed of the package. I know for sure that the LSTM module could benefit from a usenngraph = true implementation.

@nicholas-leonard
Copy link
Member

I also submitted a PR with some improvements to the benchmark : glample/rnn-benchmarks#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants