Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing baal fails when the transformers optional dep is missing #114

Closed
hadim opened this issue Mar 16, 2021 · 7 comments · Fixed by #115
Closed

Importing baal fails when the transformers optional dep is missing #114

hadim opened this issue Mar 16, 2021 · 7 comments · Fixed by #115
Labels
bug Something isn't working

Comments

@hadim
Copy link

hadim commented Mar 16, 2021

This is problematic when building the conda package since it does not include the optional dep transformers.

I see two solutions:

@hadim hadim added the bug Something isn't working label Mar 16, 2021
@hadim
Copy link
Author

hadim commented Mar 16, 2021

xref with conda-forge/baal-feedstock#1 (comment)

@Dref360
Copy link
Member

Dref360 commented Mar 16, 2021

Hello,
I think transformers is already a required deps.

https://github.com/ElementAI/baal/blob/master/requirements.txt#L13

Is there something that we are missing?

I think setting it as an optional deps would be great.

@hadim
Copy link
Author

hadim commented Mar 16, 2021

@Dref360
Copy link
Member

Dref360 commented Mar 16, 2021

Oh right! Yeah I think this comment is obsolete for now. We should assess whether we want transformers as a required deps or not.

Thank you!

@hadim
Copy link
Author

hadim commented Mar 16, 2021

Ok let me know when you took a decision for conda-forge/baal-feedstock#1

@Dref360
Copy link
Member

Dref360 commented Mar 17, 2021

I put HF as an optional dependency, do we need to push a new version to fix the conda recipe or it's good now?

@hadim
Copy link
Author

hadim commented Mar 17, 2021

A new version must be uploaded to pypi since the source of truth for the code is the sdist archive on pypi (with a sha256 hash). I closed the PR for 1.3.0 on the feedstock and will wait for 1.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants