New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing baal
fails when the transformers
optional dep is missing
#114
Comments
xref with conda-forge/baal-feedstock#1 (comment) |
Hello, https://github.com/ElementAI/baal/blob/master/requirements.txt#L13 Is there something that we are missing? I think setting it as an optional deps would be great. |
i said this because of this comment https://github.com/ElementAI/baal/blob/26bde3a9ef68454cb2795de3784cde4032fc0391/src/baal/transformers_trainer_wrapper.py#L6 Is it obsolete? |
Oh right! Yeah I think this comment is obsolete for now. We should assess whether we want transformers as a required deps or not. Thank you! |
Ok let me know when you took a decision for conda-forge/baal-feedstock#1 |
I put HF as an optional dependency, do we need to push a new version to fix the conda recipe or it's good now? |
A new version must be uploaded to pypi since the source of truth for the code is the sdist archive on pypi (with a sha256 hash). I closed the PR for 1.3.0 on the feedstock and will wait for 1.3.1. |
This is problematic when building the conda package since it does not include the optional dep
transformers
.I see two solutions:
transformers
a required deptransformers
is not imported if missing that waybaal
can still be used withouttransformers
.The text was updated successfully, but these errors were encountered: