Support arowdataset #142
Merged
Support arowdataset #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dref360
requested changes
Aug 11, 2021
tests/active/dataset_test.py
Outdated
|
|
||
| import numpy as np | ||
| import pytest | ||
| import torch | ||
| from sklearn.datasets import load_iris | ||
| from torch.utils.data import Dataset | ||
| from torch.utils.data import Dataset as torchdata |
There was a problem hiding this comment.
we often do import torch.utils.data as torchdata so this is confusing
tests/active/dataset_test.py
Outdated
| @@ -29,6 +30,29 @@ def __getitem__(self, item): | |||
| return (feature, item) | |||
|
|
|||
|
|
|||
| class MyArrowDataset(): | |||
There was a problem hiding this comment.
Can we use a real ArrowDataset? Dataset.from_pandas or something.
added 2 commits
August 11, 2021 13:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changes the pool indexing to list to be able to support pyarrow datasets. fixes #141
Checklist:
tests/documentation_test.py).