Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dry-run-example #154

Merged
merged 19 commits into from
Nov 1, 2021
Merged

dry-run-example #154

merged 19 commits into from
Nov 1, 2021

Conversation

parmidaatg
Copy link
Collaborator

Summary:

The PR will be merged as a notebook. This Draft PR is only for validation

Features:

Checklist:

  • Your code is documented (To validate this, add your module to tests/documentation_test.py).
  • Your code is tested with unit tests.
  • You moved your Issue to the PR state.

@Dref360 Dref360 mentioned this pull request Oct 4, 2021
Closed
@Dref360 Dref360 linked an issue Oct 4, 2021 that may be closed by this pull request
Implementation of BADGE #143
Closed
@Dref360 Dref360 removed a link to an issue Oct 13, 2021
Implementation of BADGE #143
Closed
@Dref360 Dref360 linked an issue Oct 13, 2021 that may be closed by this pull request
Lightning Flash Integration #149
Closed
@Dref360 Dref360 marked this pull request as ready for review November 1, 2021 13:44
parmidaatg
parmidaatg commented Nov 1, 2021
View reviewed changes
Copy link
Collaborator Author

@parmidaatg parmidaatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 👍🏼

@rafapi rafapi self-requested a review November 1, 2021 18:24
rafapi
rafapi approved these changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@rafapi rafapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black is crazy... but it all looks good 👍🏻

@Dref360 Dref360 merged commit 469ec52 into master Nov 1, 2021
@Dref360 Dref360 deleted the flash_pl_example branch November 1, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafapi rafapi rafapi approved these changes

@Dref360 Dref360 Awaiting requested review from Dref360

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lightning Flash Integration
3 participants
@parmidaatg @rafapi @Dref360