#130 Add mypy and step to test imports #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parmidaatg
approved these changes
Oct 12, 2021
| poetry run python -c "import baal; import baal.active.dataset; \ | ||
| import baal.active.heuristics; import baal.active.active_loop; \ | ||
| import baal.bayesian; import baal.calibration; import baal.modelwrapper" | ||
|
|
There was a problem hiding this comment.
why do we need to test imports? is something changing or it was for internal test?
There was a problem hiding this comment.
We need to be sure that pip install baal doesnt require HuggingFace or torchvision.
Dref360
pushed a commit
that referenced
this pull request
Oct 13, 2021
Dref360
added a commit
that referenced
this pull request
Nov 1, 2021
* dry-run-example * Fix loop * Fix nbsphinx to 0.8.6 * #130 Add mypy and step to test imports (#155) * Fix build * Fix structlog * Update flash * Update script * Log heuristic * Seems to work now * Unfreeze backbone * Reduce number of epochs * Add wd * reset epoch * Format * Update Flash and remove custom code * Split API doc in multiple files (#158) Co-authored-by: fr.branchaud-charron <fr.branchaud-charron@servicenow.com> * Lint Co-authored-by: parmida.atighehchian <parmida.atighehchian@servicenow.com> Co-authored-by: fr.branchaud-charron <fr.branchaud-charron@servicenow.com> Co-authored-by: Frédéric Branchaud-Charron <frederic.branchaud-charron@elementai.com> Co-authored-by: Dref360 <frederic.branchaud.charron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add Mypy and a step in Circle to test for imports.
Features:
Fixes #130
Checklist:
tests/documentation_test.py).