Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC should not require "jsonrpc" "2.0" in deprecated mode yet. #5782

Closed
rustyrussell opened this issue Dec 5, 2022 · 2 comments · Fixed by #5783
Closed

JSON-RPC should not require "jsonrpc" "2.0" in deprecated mode yet. #5782

rustyrussell opened this issue Dec 5, 2022 · 2 comments · Fixed by #5783
Milestone
v22.11.1

Comments

@rustyrussell
Copy link
Contributor

#5657 (comment)

Apparently BTCPayServer still wants this, so removal is premature.
@rustyrussell rustyrussell added this to the v22.11.1 milestone Dec 5, 2022
@rustyrussell rustyrussell mentioned this issue Dec 5, 2022
Merged
@vincenzopalazzo
Copy link
Collaborator

Can someone point me to this in the BTCPayServer code where the call to cln wrapped happens? I think this required less than 2 line of code to fix it, maybe we can avoid reverting it?

cc @NicolasDorier

@NicolasDorier
Copy link
Collaborator

#5783 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v22.11.1
Development

Successfully merging a pull request may close this issue.

Revert "lightningd: always require "jsonrpc": "2.0" in request." rustyrussell/lightning
3 participants
@rustyrussell @NicolasDorier @vincenzopalazzo