Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a method to get hsm_secret in bip93 format inside hsmtool #6466

Merged
merged 3 commits into from Jul 31, 2023
Merged

add a method to get hsm_secret in bip93 format inside hsmtool #6466

merged 3 commits into from Jul 31, 2023

Conversation

adi2011
Copy link
Collaborator

@adi2011 adi2011 commented Jul 31, 2023

Here getcodexsecret can be used to fetch hsm_secret in bip93 format

@adi2011 adi2011 force-pushed the RecoverCodex32 branch 2 times, most recently from 894903d to a21335f Compare July 31, 2023 04:22
rustyrussell
rustyrussell requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some memory problems, and a little neatening.,

Would also like you to append to that existing recovery test, that the hsm secret does extract back as the correct bip93 string?

common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.c Outdated Show resolved Hide resolved
rustyrussell
rustyrussell reviewed Jul 31, 2023
View reviewed changes
common/codex32.c Outdated Show resolved Hide resolved
common/codex32.h Outdated Show resolved Hide resolved
@rustyrussell rustyrussell added this to the v23.08 milestone Jul 31, 2023
rustyrussell
rustyrussell approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 30c73a9

@rustyrussell rustyrussell merged commit 6a734d8 into ElementsProject:master Jul 31, 2023
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustyrussell rustyrussell rustyrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.08
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adi2011 @rustyrussell