-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash in renepay plugin #6493
Comments
We should not make renepay marked as important, I do not think it has enough tests to do it? Maybe this underflow is easier for @Lagrang3 to debug? assigning to it till I will be away from my desk |
First thing I notice is that invoice string comes before the payment parameters otherwise the parser will not let you continue. Can you upload more details of the logs, to simplify maybe just the lines containing |
Sorry, I did get the BOLT11 in before the parameters in the actual test. The report is updated to reflect that. That was all the log output I received - there was no traceback available. Will see if I can up the logging level and get some more details. |
Actually, I think I don't need any more log messages. I seems like the |
As a builtin plugin, the |
If there is no possibility to do it, we should add it. Till now, all the plugins built-in are important (except grpc one), but we should have the possibility to say, "it is fine if this plugin dies" |
@rustyrussell just PR this #6523 to avoid crashing the node. |
@rustyrussell there is also the fix to the underflow that triggered this issue #6505 |
My fault I was assuming that this was already merged |
I believe this should be fixed by #6538 |
Issue and Steps to Reproduce
ran
lightning-cli renepay <bolt 11> 50000 40000
to test a 50sat paymentwhich lead to the following crash:
Running 23.08rc1
The text was updated successfully, but these errors were encountered: