Renepay crash on sendpay failure

[endothermicdev]

Issue and Steps to Reproduce

A failed payment returned a gossip update and WIRE_INCORRECT_CLTV_EXPIRY which seemed to lead to a crash. Running commit 98c805e.

2023-08-08T14:20:18.174Z INFO    02...b2-chan#83: htlc 3002 failed from 0th node with code 0x100d (WIRE_INCORRECT_CLTV_EXPIRY)
2023-08-08T14:20:18.179Z DEBUG   lightningd: io_break: db_hook_response
2023-08-08T14:20:18.180Z DEBUG   lightningd: io_loop: plugins_exclusive_loop
2023-08-08T14:20:18.189Z DEBUG   plugin-cln-renepay: I received a sendpay_failure with key key: groupid=2, partid=3, payment_hash=e0449a9bb9c60eb09a0ca909dac0d6f107ce5c5cb0600d28cedc2054ad95d777
2023-08-08T14:20:18.190Z UNUSUAL plugin-cln-renepay: onion error WIRE_INCORRECT_CLTV_EXPIRY from node #1 800359x1143x3: failed: WIRE_INCORRECT_CLTV_EXPIRY (reply from remote)
2023-08-08T14:20:18.190Z DEBUG   plugin-cln-renepay: onion error WIRE_INCORRECT_CLTV_EXPIRY from node #1 800359x1143x3: failed: WIRE_INCORRECT_CLTV_EXPIRY (reply from remote)
2023-08-08T14:20:18.190Z DEBUG   plugin-cln-renepay: sendpay_failure, apply channel_update
2023-08-08T14:20:18.191Z DEBUG   plugin-cln-renepay: calling submit_update
2023-08-08T14:20:18.191Z DEBUG   plugin-cln-renepay: ... extracted channel_update, telling gossipd
2023-08-08T14:20:18.191Z DEBUG   plugin-cln-renepay: (update = 01024d32441b4136fca45f04b858dcdcd0c9323f2e6c6a27265de717e0989905f47641c2ab05c3a54f9333a3bba24042ee9ba3498eeefabbd0f8214bf6c2e44929506fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d61900000000000c3667000477000364d195c00100005000000000000003e80000000000000001000000049c2c0600)
2023-08-08T14:20:18.192Z DEBUG   plugin-clnrest.py: Notification: {'sendpay_failure': {'code': 204, 'message': 'failed: WIRE_INCORRECT_CLTV_EXPIRY (reply from remote)', 'data': {'id': 4141, 'payment_hash': 'e0449a9bb9c60eb09a0ca909dac0d6f107ce5c5cb0600d28cedc2054ad95d777', 'groupid': 2, 'partid': 3, 'destination': '02e9abd50c0d0868eb8ae081dd01d885a395379c9a4c108a4565c81c45c9ca9d07', 'amount_msat': 1000000, 'amount_sent_msat': 1000242, 'created_at': 1691504408, 'status': 'pending', 'bolt11': 'lnbc10u1pjdynnasp5d3lt6tgr3h5eqm96rs5frsp7hqeeyqermmp4v9qa3548esj69gfqpp5upzf4xaecc8tpxsv4yya4sxk7yruuhzukpsq62xwmss9ftv46amsdpcyfnx2etyyp3ks6trddjkuueqw3hkketwwv75z5j3g4j5ynzpd9nhw0fzxqzfvcqpjrzjq0k9zg6z4mhrwz6nm8739k749q7u6ecdyjqp3vapeafhxyl8de4z6zajryqq2fqqqyqqqqlgqqqq8ncq9q9qxpqysgqc086je295z3zjaclmcurzrkpe6amf7l2cyy3x7hpjk9x00zcuyk3kz8hg2jxjz0x7u0ywpanha99ultl6k39e278zmlt7k2xt0wgjgqpk06sag', 'erring_index': 1, 'failcode': 4109, 'failcodename': 'WIRE_INCORRECT_CLTV_EXPIRY', 'erring_node': '02...b2', 'erring_channel': '800359x1143x3', 'erring_direction': 0, 'raw_message': '100d000c40ed00884d32441b4136fca45f04b858dcdcd0c9323f2e6c6a27265de717e0989905f47641c2ab05c3a54f9333a3bba24042ee9ba3498eeefabbd0f8214bf6c2e44929506fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d61900000000000c3667000477000364d195c00100005000000000000003e80000000000000001000000049c2c0600'}}}
2023-08-08T14:20:18.193Z DEBUG   02...b2-channeld-chan#83: ... , awaiting 1122
2023-08-08T14:20:18.195Z DEBUG   plugin-clnrest.py: Notification: {'warning': {'level': 'warn', 'time': '1691504418.190040796', 'timestamp': '2023-08-08T14:20:18.190Z', 'source': 'plugin-cln-renepay', 'log': 'onion error WIRE_INCORRECT_CLTV_EXPIRY from node #1 800359x1143x3: failed: WIRE_INCORRECT_CLTV_EXPIRY (reply from remote)'}}
2023-08-08T14:20:18.196Z DEBUG   02...b2-channeld-chan#83: Got it!
2023-08-08T14:20:18.197Z DEBUG   gossipd: Received (forced) channel_update for channel 800359x1143x3/0 now ACTIVE
2023-08-08T14:20:18.197Z DEBUG   02...b2-channeld-chan#83: revoke_and_ack LOCAL: remote_per_commit = 0221ef09df4823561279a8f373dfde61afb2d20a32ef8c757639c15606fc6bef68, old_remote_per_commit = 02e87964919349ffb3771eaf7441f3495d8ad3439184a080f5c782e890fc1adbb0
2023-08-08T14:20:18.198Z DEBUG   gossipd: REPLY WIRE_GOSSIPD_ADDGOSSIP_REPLY with 0 fds
2023-08-08T14:20:18.205Z DEBUG   02...b2-channeld-chan#83: Trying commit
2023-08-08T14:20:18.205Z DEBUG   02...b2-channeld-chan#83: Can't send commit: nothing to send, feechange not wanted ({ SENT_ADD_ACK_REVOCATION:6126 }) blockheight not wanted ({ SENT_ADD_ACK_REVOCATION:0 })
2023-08-08T14:20:18.219Z DEBUG   plugin-clnrest.py: Emitting message: {'sendpay_failure': {'code': 204, 'message': 'failed: WIRE_INCORRECT_CLTV_EXPIRY (reply from remote)', 'data': {'id': 4141, 'payment_hash': 'e0449a9bb9c60eb09a0ca909dac0d6f107ce5c5cb0600d28cedc2054ad95d777', 'groupid': 2, 'partid': 3, 'destination': '02e9abd50c0d0868eb8ae081dd01d885a395379c9a4c108a4565c81c45c9ca9d07', 'amount_msat': 1000000, 'amount_sent_msat': 1000242, 'created_at': 1691504408, 'status': 'pending', 'bolt11': 'lnbc10u1pjdynnasp5d3lt6tgr3h5eqm96rs5frsp7hqeeyqermmp4v9qa3548esj69gfqpp5upzf4xaecc8tpxsv4yya4sxk7yruuhzukpsq62xwmss9ftv46amsdpcyfnx2etyyp3ks6trddjkuueqw3hkketwwv75z5j3g4j5ynzpd9nhw0fzxqzfvcqpjrzjq0k9zg6z4mhrwz6nm8739k749q7u6ecdyjqp3vapeafhxyl8de4z6zajryqq2fqqqyqqqqlgqqqq8ncq9q9qxpqysgqc086je295z3zjaclmcurzrkpe6amf7l2cyy3x7hpjk9x00zcuyk3kz8hg2jxjz0x7u0ywpanha99ultl6k39e278zmlt7k2xt0wgjgqpk06sag', 'erring_index': 1, 'failcode': 4109, 'failcodename': 'WIRE_INCORRECT_CLTV_EXPIRY', 'erring_node': '02...b2', 'erring_channel': '800359x1143x3', 'erring_direction': 0, 'raw_message': '100d000c40ed00884d32441b4136fca45f04b858dcdcd0c9323f2e6c6a27265de717e0989905f47641c2ab05c3a54f9333a3bba24042ee9ba3498eeefabbd0f8214bf6c2e44929506fe28c0ab6f1b372c1a6a246ae63f74f931e8365e15a089c68d61900000000000c3667000477000364d195c00100005000000000000003e80000000000000001000000049c2c0600'}}}
2023-08-08T14:20:18.220Z DEBUG   plugin-clnrest.py: Emitting message: {'warning': {'level': 'warn', 'time': '1691504418.190040796', 'timestamp': '2023-08-08T14:20:18.190Z', 'source': 'plugin-cln-renepay', 'log': 'onion error WIRE_INCORRECT_CLTV_EXPIRY from node #1 800359x1143x3: failed: WIRE_INCORRECT_CLTV_EXPIRY (reply from remote)'}}
2023-08-08T14:20:18.580Z INFO    plugin-cln-renepay: Killing plugin: exited during normal operation

[rustyrussell]

Hopefully fixed by #6538