Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom "pay" text and button don't show complete sentence. #4

Closed
reathh opened this issue Jul 22, 2018 · 2 comments
Closed

Custom "pay" text and button don't show complete sentence. #4

reathh opened this issue Jul 22, 2018 · 2 comments

Comments

@reathh
Copy link

reathh commented Jul 22, 2018

Using the example from your "Usage" section
[ifpaid 0.005 ILS text="Please pay to continue reading." button="Alright, I'll pay!"]

Only the first word in the quotes becomes visible (and also the first quote, which shouldn't be like that):
2018-07-22_15-26-40

@shesek
Copy link
Collaborator

shesek commented Jul 22, 2018

It looks like something is changing your quotes from the regular " to a , which are not properly parsed as wordpress shortcodes. Some plugin getting in the way, maybe?

It seems that I've previously ran into it and added some code to manually convert the closing mark (aka ”) but not the opening one (aka “).

I updated the shortcode parser to manually convert both of them in 57e240f. Can you try and verify it works?

shesek referenced this issue Jul 22, 2018
… mark" to regular quotes when parsing shortcodes
@reathh
Copy link
Author

reathh commented Jul 22, 2018

#57e240f fixed the issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants