Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can "server_url" be a link with a path? #5

Closed
NicolasDorier opened this issue Oct 30, 2018 · 12 comments
Closed

Can "server_url" be a link with a path? #5

NicolasDorier opened this issue Oct 30, 2018 · 12 comments

Comments

@NicolasDorier
Copy link

@shesek I plan to integrate lightning-charge to BTCPay as an option.
But, because we don't want to require users to open new ports, we use URL rewriting on nginx. (like https://btcpay.example.com/clightning-charge/btc/)

Will this work fine with wordpress lightning publisher?

@pieman64
Copy link

@NicolasDorier if you need anyone to test things just give me a shout.

@shesek
Copy link
Collaborator

shesek commented Oct 31, 2018

Yes, it should work alright. But note that Lightning Publisher also uses the checkout page provided by Lightning Charge as an iframe, which I guess would add more complexity on your side?

Of the Charge-based Lapps I wrote, only Lightning Publisher and nanotip rely on the embedded checkout page. The other Lapps display payments information on their own and rely solely on the API.

@NicolasDorier
Copy link
Author

well it seems easy for me to steal as long as I can put them in any path I want.

@shesek
Copy link
Collaborator

shesek commented Oct 31, 2018

Then yes, you can. Note that you have two configurable URLs: server_urlwhich is used for talking with the API, and public_url which is used for the iframe.

@pieman64
Copy link

pieman64 commented Nov 1, 2018

Any news @NicolasDorier on the publisher mods?

@NicolasDorier
Copy link
Author

no, have not start working on the API in btcpay

@NicolasDorier
Copy link
Author

@pieman64 it is done, please try https://twitter.com/BtcpayServer/status/1076025576845017088

@pieman64
Copy link

Thanks @NicolasDorier I will switch my node from LND to c-lightning in the coming days and try it out.

@NicolasDorier
Copy link
Author

@pieman64 check https://www.youtube.com/watch?v=ZbM3jcxau0o

Closing this issue

@pieman64
Copy link

Thanks @NicolasDorier we set it up a few days ago on our site after following developments in the BTCpay Slack channel.

https://buycryptonewsarticles.com/ethereum-etc-faucet/

@NicolasDorier
Copy link
Author

Very cool :D
Though paying for a ethereum article via BTC with lightning won't get you lot's of customers aha.

@pieman64
Copy link

@NicolasDorier never thought of that. We simply added Publisher to an article we had written previously. I am following this issue btcpayserver/btcpayserver#50 in the hope that ERC tokens will be available at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants