Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning session: Peer-to-peer code review Module 2 - Week 3 - 22 Feb 2022 #7

Open
Tufahel opened this issue Feb 22, 2022 · 1 comment

Comments

@Tufahel
Copy link

Tufahel commented Feb 22, 2022

Hi @Elerqsousy, You have done a great job. Every functionality of the project is ok and the interface is also looking good. Here are some suggestions that you can consider :
1.

  • You can consider using retrun this inside the class for method chaining. Here is an example from this article :
    Screenshot from 2022-02-22 13-29-53
    Screenshot from 2022-02-22 13-30-19
  • Inside this function, it exists a single line. This is not a multiline function and it's a good practice for writing javascript code not to use multiline for single line function.
    newList.forEach((e) => {
  • This to-do list is taking blank comments. Consider using required inside input tag.
    Screenshot from 2022-02-22 13-37-11

Happy Coding 👍

@damdafayton
Copy link

@Tufahel Tufahel changed the title Morning session: Peer-to-peer code review Module 2 - Week 3 Morning session: Peer-to-peer code review Module 2 - Week 3 - 22 Feb 2022 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants