Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mutransfer #679

Closed
5 of 7 tasks
Quentin-Anthony opened this issue Sep 20, 2022 · 4 comments
Closed
5 of 7 tasks

Add support for mutransfer #679

Quentin-Anthony opened this issue Sep 20, 2022 · 4 comments
Assignees
Labels
feature request New feature or request

Comments

@Quentin-Anthony
Copy link
Member

Quentin-Anthony commented Sep 20, 2022

We should add support for mutransfer: https://github.com/microsoft/mup

Appears non-trivial, but not as difficult as MoE. We'd have to modify the model itself. https://github.com/microsoft/mup/blob/main/examples/Transformer/model.py appears especially relevant. A good workflow would be:

  • Run mutransfer transformer example to gain familiarity with how their codebase behaves.
  • Make necessary changes in gpt-neox/megatron/model/ to use mup. Probably mostly in transformer.py
  • Add muSGD and muAdam to gpt-neox/megatron/optimizers.py
  • Update gpt-neox/megatron/training.py to allow previous features to be selected during training
  • Add neox_args to choose the options in step 4
  • Test and add example config
  • Add args for saving coord check plot
@Quentin-Anthony Quentin-Anthony added the feature request New feature or request label Sep 20, 2022
@nsarka nsarka self-assigned this Oct 17, 2022
@nsarka
Copy link
Contributor

nsarka commented Oct 18, 2022

nsarka/mup-support has my changes for this so far. I haven't tested it.

There's one more thing to add to this list. Mup can generate a plot that's helpful for checking the correctness of the implementation. https://github.com/microsoft/mup#checking-correctness-of-parametrization

  • Add args for saving coord check plot

@StellaAthena
Copy link
Member

nsarka/mup-support has my changes for this so far. I haven't tested it.

There's one more thing to add to this list. Mup can generate a plot that's helpful for checking the correctness of the implementation. https://github.com/microsoft/mup#checking-correctness-of-parametrization

  • Add args for saving coord check plot

Great work! Thank you for this contribution ^_^

Don’t forget to add yourself as a library contributor in the readme as well 😉

@nsarka
Copy link
Contributor

nsarka commented Oct 19, 2022

Thanks Stella! I added myself as a contributor in the draft PR here #704 :)

@StellaAthena
Copy link
Member

Closed as completed by #704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants