Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Visualization Code into Main #19

Merged
merged 13 commits into from Mar 1, 2022
Merged

Merge Visualization Code into Main #19

merged 13 commits into from Mar 1, 2022

Conversation

shahbuland
Copy link
Contributor

Overview of changes:

  • Created vis folder
  • Added PCA visualization of random dataset samples embedded
  • Extended above with spherical coordinates
  • Copied carp_cloob config (maybe unnecessary?)

@LouisCastricato
Copy link
Collaborator

Can you post screenshots of the visualization?

@LouisCastricato
Copy link
Collaborator

Also can we move this to examples/vis?

@shahbuland
Copy link
Contributor Author

Screenshots posted under vis/figures with annotations, and folder has been moved. UMAP is also integrated now .

@LouisCastricato
Copy link
Collaborator

LouisCastricato commented Feb 27, 2022

LGTM. Can you run black?
Eg
make style

You might need to merge from main before you do so though.

@LouisCastricato LouisCastricato merged commit 9cc2d93 into main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants