Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a user clicks the popup content, popup up closes #22

Open
jibinycricket opened this issue Aug 16, 2018 · 4 comments
Open

When a user clicks the popup content, popup up closes #22

jibinycricket opened this issue Aug 16, 2018 · 4 comments
Assignees
Labels
bug 🐞 Something isn't working

Comments

@jibinycricket
Copy link

Bug: When a user clicks inside the popup the entire popup closes.
Expected: Clicking the overlay or close button should close the popup. When clicking the popup content, the popup should remain open

@Anubarak
Copy link

@jmathew1991 I'm not sure if that's intended or not but you can just use an older version of the plugin

@oscarstranger oscarstranger added the bug 🐞 Something isn't working label Sep 12, 2018
@oscarstranger oscarstranger self-assigned this Sep 12, 2018
@oscarstranger
Copy link
Contributor

oscarstranger commented Sep 12, 2018

@jmathew1991 Thanks for raising this issue, it sounds like a bug to me. This may have been caused during our recent rewrite in vanilla JS.

As an immediate fix, feel free to install the previous release while we work to fix this issue.

@Anubarak
Copy link

@oscarstranger So I guess this library is dropped by now?

@Cam
Copy link
Member

Cam commented Dec 15, 2020

@Anubarak sort of yes, sort of no. A replacement is coming soon that is much much better than the current library.

PRs are very welcome on this though.

@Cam Cam assigned Cam and unassigned Cam and oscarstranger Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants