Add minor changes to matching engine logic #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-chen
reviewed
Mar 13, 2023
| spawn("prettier", ["--write", sdkDir], { stdio: "inherit" }) | ||
| .on("error", (err) => { | ||
| console.error( | ||
| "Failed to lint client files. Try installing prettier (`npm install --save-dev --save-exact prettier`)" |
There was a problem hiding this comment.
add comment that we should add a prettier config here (otherwise, will default to whatever your local prettier has rather than being consistent)
There was a problem hiding this comment.
Good call, if you have one, can you quickly paste to this PR. Not opinionated here
There was a problem hiding this comment.
just leave the comment for now and we can add one in if a future diff comes in that looks ugly. As long as the default includes semicolons and double-quotes since that's what all of our editors currently do
eugene-chen
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: