Phoenix v1/crate boundaries #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-chen
reviewed
Feb 14, 2023
|
|
||
| [lib] | ||
| crate-type = ["cdylib", "lib"] | ||
| name = "phoenix" |
There was a problem hiding this comment.
should we call this phoenix-v1?
idl/package.json
Outdated
| "dependencies": { | ||
| "@metaplex-foundation/rustbin": "^0.3.1" | ||
| } | ||
| "name": "phoenix", |
idl/package.json
Outdated
| } | ||
| "name": "phoenix", | ||
| "version": "1.0.0", | ||
| "description": "SDK for phoenix", |
There was a problem hiding this comment.
probably also phoenix-v1?
idl/package.json
Outdated
| "version": "1.0.0", | ||
| "description": "SDK for phoenix", | ||
| "main": "index.ts", | ||
| "license": "MIT", |
There was a problem hiding this comment.
is this correct? what does this apply to?
| @@ -1,15 +1,15 @@ | |||
| pub mod accounts; | |||
| pub mod dispatch_market; | |||
| pub mod error; | |||
| pub mod event_recorder; | |||
| pub(crate) mod event_recorder; | |||
There was a problem hiding this comment.
nit: sort imports so pub(crate)s go together
eugene-chen
approved these changes
Feb 14, 2023
eugene-chen
pushed a commit
that referenced
this pull request
Feb 14, 2023
Changes: - Partition structs and functions into `pub(crate)` and `pub` - Introduce a `WritableMarket` trait to create a logical separation between read/write functionality in the market Run clippy and add new instruction file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
pub(crate)andpubWritableMarkettrait to create a logical separation between read/write functionality in the market