Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session_cookie's _update_db not guaranteed to update. #2086

Closed
dionysiosarvanitis opened this issue Dec 19, 2012 · 2 comments
Closed

Session_cookie's _update_db not guaranteed to update. #2086

dionysiosarvanitis opened this issue Dec 19, 2012 · 2 comments

Comments

@dionysiosarvanitis
Copy link
Contributor

In case of something goes wrong during a database action and DB_driver's display_error() gets called, the query_builder doesn't get cleared causing a conflict with the subsequent update of the register_shutdown_function _update_db(). For example, with some data in a order_by clause.

Shouldn't we reset the $db before display_error()?
@narfbg
Copy link
Contributor

narfbg commented Dec 20, 2012

Sounds good, care to make a pull request?

@dionysiosarvanitis
Copy link
Contributor Author

Take a look on pull #2267.

@dionysiosarvanitis dionysiosarvanitis mentioned this issue Feb 19, 2013
Merged
narfbg added a commit that referenced this issue Feb 19, 2013
@narfbg
Merge pull request #2267 from dionysiosarvanitis/fix/_update_db
00c3201 
Issue #2086 Session_cookie's _update_db not guaranteed to update
@narfbg narfbg closed this as completed Feb 19, 2013
nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013
@dionysiosarvanitis
Issue bcit-ci#2086 Session_cookie's _update_db not guaranteed to update
558cc3f
nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013
@narfbg
Merge pull request bcit-ci#2267 from dionysiosarvanitis/fix/_update_db
ff83211 
Issue bcit-ci#2086 Session_cookie's _update_db not guaranteed to update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@narfbg @dionysiosarvanitis