Error messages in form_validation_lang.php not contained in a namespace

[bobosayhello]

For example, it should be:

$lang['form_validation_min_length']="The %s field must be at least %s characters";

Rather than:

$lang['min_length']="The %s field must be at least %s characters";

[ericlbarnes]

I agree with you, however I don't think it would be good to change it because it would then break all existing sites when they upgrade.

[bobosayhello]

I see your point, maybe possible in CI3.

[narfbg]

With CI 3.0 coming soon, we better decide on this one soon.

+1 from me, if it's done with a proper explanation in the upgrade guide.
Although we could put a work-around for it to fallback to the old, non-prefixed entries if no e.g. fv_ prefixed values are found. The work-around should then be removed in CI 3.1+.

Any other opinions?

[narfbg]

See the above referenced commit.

[keatliang2005]

One question, the format tweaks is for the custom callback rule and the field name too

suggest just apply only for callbacks

array(
                'field' => 'fieldname',
                'label' => 'lang:fieldname',     #bit tedious for converting this
                'rules' => 'required|callback__validate_fieldname'  #yes suggest just prefix this ....
);

what do you guys think ?

[narfbg]

I can't understand what you're trying to say.

[keatliang2005]

what i mean is from
i suggest the label when using language

'label' => 'lang:fieldname'

form_validation_fieldname # it is very much not convenient to name spacing this 

no need to using language key name spacing.
just for the callback function will do.

sorry for my bad english

what i mean is just namspacing the callback language key that's enough,