Character issue on Cart Class

[bitbucket-import]

Hello,

I was itching my head when I was trying out the cart class. Because some products was added nicely, but some wouldn't at all. Without any error.

After some head scratching I found out that this line is the problem for us that lives in scandinavia, and possibly many other countries.

var $product_name_rules = '\.\:\-_ a-z0-9'; // alpha-numeric, dashes, underscores, colons or periods

located in system/libraries/Cart.php

The reason is we use ÆØÅ in our product names and therefor it will fail.

So I suggest to add a config item that we can add local characters on and the CI_Cart can fetch those from there. Instead of "hacking the core". That's one option.

This is the working code for me.

var $product_name_rules = '\.\:\-_ a-zæøåÆØÅ0-9'; // alpha-numeric, dashes, underscores, colons or periods

Best regards
Anthoni Giskegjerde ( @antonigiske )

[michail1982]

Addon..
Cart not use unicode switch by testing product name
Thats case a need to use
var $product_name_rules = '.:-_ a-z0-9_-а-яА-Я';
instate of
var $product_name_rules = '.:-_ a-z0-9_-а-я';
woold be helpful to add unicode switch
if ( ! preg_match("/^[".$this->product_name_rules."]+$/ui", $items['name']))
and ability to set product_name_rules via config

[narfbg]

Unicode support has already been added and the product_name_rules property is public, so you can easily alter the rule for non-latin characters. Furthermore, the rule has been changed to allow "word characters" instead of just 'a-z'.

[ibadgore]

How about
/*
if ( ! preg_match("/^[".$this->product_name_rules."]+$/i", $items['name']))
{
log_message('error', 'An invalid name was submitted as the product name: '.$items['name'].' The name can only contain alpha-numeric characters, dashes, underscores, colons, and spaces');
return FALSE;
}
*/