Work on determination of "base_url" config item

[vlakoff]

• A little refactoring.
• Remove the basename only at the end, to avoid edge cases.

[vlakoff]

Also, shouldn't we remove the manual setting of this config item?
It seems unnecessary for long, are there some use cases for this?

[narfbg]

It's not unnecessary, it's a must. This auto-detection is a fallback that no serious application should really use - it's not reliable.

What are the benefits from your refactoring?

[vlakoff]

The refactoring won't change anything in practice, but that's because the $_SERVER['HTTP_HOST'] fallback itself isn't really useful (at least in its current state).

edit: It looks like the autodetection would need some work to be usable in CLI.

[narfbg]

I'm not really sure I understand you ... I don't see how it can be made more useful since it is based on an HTTP header.

Also, why is that test "unfit"? :)

[vlakoff]

I thought of it as useless, because making sense only on a local server and using a HTTP 1.0 client.

However I didn't think about CLI at the beginning.

Straight to the point, considering the results of autodetection in CLI, and my refactoring not improving that situation, I'd suggest leaving that part out, opening a new PR with only the changes of 2516f3b + 93836ff. Is this OK for you?

[narfbg]

Ignore CLI, it's natural that you don't have a base URL under CLI. I'm still having a hard time understanding what you're trying to solve here though? Is this a performance improvement? Or fixing unexpected behavior?

[vlakoff]

It's in case the script name would be in the path too. Yes, this is veeery unlikely, but I think a robust code should not rely on unlikeliness.

[narfbg]

Hehe, I'd sure would love to see who has their directory named 'index.php'. ;) But ok ... it makes sense. Just a few tips:

• str_replace() is faster than strtr().
• No spaces around concatenation.
• Instead of preg_replace(), this should do:
  
substr($_SERVER['SCRIPT_NAME'], 0, -strlen(basename($_SERVER['SCRIPT_NAME'])));


[vlakoff]

• not for single-character replacements ;-)
• ok
• good catch, done in b208f65

Also, added a test (3802d70)

If you're OK with the changes, I'll make a streamlined PR, keeping this one for the sake of documentation.

[narfbg]

No, this one is fine. :)

[aanbar]

lines 89 & 90 are not needed anymore in Config_test.php

[narfbg]

They are.

[aanbar]

These are already defined in line 70-72 am I missing something?

[narfbg]

Yes, you are. :)

[aanbar]

Just noticed it, You're modifying the _SERVER