Improve the Email library #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $this->newline = $newline; | ||
|
|
||
| $this->newline = ($newline !== "\n" AND $newline !== "\r\n" AND $newline !== "\r") ? "\n" : $newline; |
There was a problem hiding this comment.
Would ! in_array() be better here?
|
Ok ... updated the patch. |
philsturgeon
pushed a commit
that referenced
this pull request
Dec 22, 2011
Improve the Email library
|
Thanks again! You're doing good work here and it is appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
NOTE:
I intend to do this for each of the libraries (and probably other stuff as well) separately as none of my similar pull requests that have changes to multiple classes have been accepted - I hope those make it.
With that in mind - I'll just add one line under general changes in the change log when it's all done, to avoid multiple entries with the same description and only the class name changed.