Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Frame does not like being beside another Custom Frame when placed on the Sidebars #19

Closed
ceciliamay opened this issue Apr 4, 2022 · 5 comments

Comments

@ceciliamay
Copy link

Hey there @Ellpeck !! This plugin is making me smile everytime I use it. I can't thank you enough for this!! Onto the issue...

Problem:
Custom Frame does not like being beside another Custom Frame when placed on the Sidebars

How to Replicate:
Add a custom frame and put it to the left sidebar. Add another custom frame and drag it over to left sidebar to be beside the first custom frame.

Expected Behavior:
The new custom frame sits beside the first custom frame.

Current Behavior:
It is very hard to "aim" for the new custom frame to sit beside the other custom frame. It only wants to be on the top or bottom.

I am trying to use my left sidebar as my go to search area/other tools hotspot with all the custom frames I added. Unfortunately, I can't put them all in line due to this bug.

@Ellpeck
Copy link
Owner

Ellpeck commented Apr 5, 2022

Hi! Does this problem get less bad/go away if you increase the padding in the settings menu? It's the first option right at the top.

It seems like this issue generally happens when you try to move anything around over the actual embed, as that makes the mouse go wonky. Increasing the padding should give you a bigger area that allows for anchoring the panes like you want.

Unfortunately, I've yet to find a way to fix this permanently (and to allow dragging over the embed without any trouble), and it seems like it might be an Obsidian issue, and not a plugin issue.

@ceciliamay
Copy link
Author

Ha!! I forgot about the padding. (mainly cause I set it at 0 when I saw it 😂) It works!! Thanks for this!!

Workaround:

  1. Increase padding up to 15px for Custom Frames
  2. Setup all custom frames and open them
  3. Drag the custom frames, and when adding a new one beside it, drag it to the left/right padding
  4. Drop
  5. Save Workspace setup
  6. [optional] Go back to Custom Frames and set padding to 0 (if you still want the 0px padding)
  7. Reload
  8. Yaaay!!

image

Thank you @Ellpeck for looking into this!!

@marcjulianschwarz
Copy link

I don't know if this is the same problem or not. I am having issues resizing the frames (panes with frame inside). Making it wider is working perfectly however it starts behaving a bit weird when trying to make it narrower.

Where would I need to put the padding on? The body of a frame?

Attached a video showing the issue.

2022-04-11.21-24-46.mp4

@marcjulianschwarz
Copy link

marcjulianschwarz commented Apr 11, 2022

Well, just got it fixed.

For anyone reading this:
You can add 15-20px of padding on .custom-frames-frame and move the mouse slowly to prevent entering the iframe.

Seems to be a general iframe issue where the app/website doesn't get a drag-end event since the drag event stopped inside of the frame. So the drag will just continue forever.

@Ellpeck
Copy link
Owner

Ellpeck commented Apr 11, 2022

This issue has been fixed in the most recent Insiders release of Obsidian (0.14.6).

Repository owner locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants