Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to interface defs for custom C# types #108

Merged
merged 2 commits into from Jan 27, 2023
Merged

Conversation

elringus
Copy link
Owner

Custom C# types are marshaled to JSON objects on JS, so it's not correct to represent them as classes. This will change the generated TS declarations to interfaces.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b6098da) compared to base (15381ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         1546      1533   -13     
  Branches       157       156    -1     
=========================================
- Hits          1546      1533   -13     
Impacted Files Coverage Δ
...r/DeclarationGenerator/TypeDeclarationGenerator.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elringus elringus merged commit 149cd68 into main Jan 27, 2023
@elringus elringus deleted the feat/use-ts-interfaces branch January 27, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant