Make public API masking optional #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for multiversx-nextjs-dapp pending review.Visit the deploys page to approve it
|
janniksam
commented
Dec 4, 2022
janniksam
force-pushed
the
feature/makeApiMaskingOptional
branch
from
1a72b6d
to
f8182e0
Compare
juliancwirko
reviewed
Dec 4, 2022
juliancwirko
reviewed
Dec 4, 2022
janniksam
force-pushed
the
feature/makeApiMaskingOptional
branch
2 times, most recently
from
4929f04
to
5222301
Compare
janniksam
force-pushed
the
feature/makeApiMaskingOptional
branch
from
5222301
to
027fdb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing / commenting out the enviroment variable
NEXT_PUBLIC_MULTIVERSX_APIthe maskin of the public MultiversX api can be disabled. When masking is disabled all api requests done by the dapp will go directly to the public api endpoint.Further more I've simplified the access to the active network configuration. We can use
activeNetworkConfiguration-method to get the active network configuration, if we don't want to retrieve a specific configuration for a given chainType.Fixes #18