Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed closing the bootstrap storage #1497

Merged
merged 1 commit into from
May 1, 2020
Merged

fixed closing the bootstrap storage #1497

merged 1 commit into from
May 1, 2020

Conversation

iulianpascalau
Copy link
Contributor

  • fixed closing the bootstrap storage if an error occurred when trying to fetch initial data from that storage
  • added waiting time and retries when opening a persister. This will prevent returning immediately when encountering the "resource temporarily unavailable" error
  • added a fix to the levelDB implementation so close can be called multiple times

@iulianpascalau
- fixed closing the bootstrap storage if an error occurred when tryin…
923e531 
…g to fetch initial data from bootstrap storage

- added a waiting time and retries when opening a persister. This will prevent returning immediately when encountering "resource temporarily unavailable" error
- added a fix to the levelDB implementation so close can be called multiple times
@iulianpascalau iulianpascalau self-assigned this Apr 30, 2020
@iulianpascalau iulianpascalau added the type:bug Something isn't working label Apr 30, 2020
@sasurobert sasurobert self-requested a review April 30, 2020 16:41
@iulianpascalau iulianpascalau changed the title - fixed closing the bootstrap storage if an error occurred when tryin… fixed closing the bootstrap storage Apr 30, 2020
LucianMincu
LucianMincu approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 507dc5a into development May 1, 2020
@LucianMincu LucianMincu deleted the fix-unclosed-bootstrap-persister branch May 1, 2020 12:31
This was referenced May 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@AdoAdoAdo AdoAdoAdo AdoAdoAdo approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@iulianpascalau iulianpascalau

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iulianpascalau @sasurobert @LucianMincu @AdoAdoAdo @SebastianMarian @bogdan-rosianu