Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cleaning of header cache after the block tracker initialization #1503

Merged
merged 2 commits into from
May 1, 2020
Merged

fixed cleaning of header cache after the block tracker initialization #1503

merged 2 commits into from
May 1, 2020

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented May 1, 2020 •
edited

  • fixed edge case when received metablocks were added in cache before the block tracker initialization leading to perpetual requests of metablocks that were actually long time received
  • fixed trie node requester log prints
  • fixed the event timestamp in resolver debugger
  • changed some log prints into log.Trace
  • changed the order of the nodesSetup fields

@iulianpascalau
- fixed edge case when received metablocks were added in cache before…
acc99de 
… the block tracker initialization leading to perpetual requests of metablocks that wer actually long time received

- fixed trie node requester log prints
- fixed the event timestamp in resolver debugger
- changed some log prints into log.Trace
- changed the order of the nodesSetup fields
@iulianpascalau iulianpascalau self-assigned this May 1, 2020
@iulianpascalau iulianpascalau added the type:bug Something isn't working label May 1, 2020
@SebastianMarian SebastianMarian self-requested a review May 1, 2020 13:39
@sasurobert sasurobert self-requested a review May 1, 2020 13:44
LucianMincu
LucianMincu approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit a571c54 into development May 1, 2020
@LucianMincu LucianMincu deleted the header-cache-clean-after-blocktracker-init branch May 1, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees

@iulianpascalau iulianpascalau

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iulianpascalau @sasurobert @LucianMincu @SebastianMarian