Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

En 6282 observer nodes shuffled out fix #1537

Merged
merged 24 commits into from
May 13, 2020

Conversation

raduchis
Copy link
Contributor

@raduchis raduchis commented May 8, 2020

unstake nodes were not actually removed from the network.
leaving nodes were set to observer status and moved to shard zero and it appeared they are reshuffled
priority given to unstake Nodes before rating leaving nodes

@sasurobert sasurobert self-requested a review May 8, 2020 11:37
@AdoAdoAdo AdoAdoAdo self-requested a review May 8, 2020 13:05
@multiversx multiversx deleted a comment May 8, 2020
@raduchis raduchis marked this pull request as ready for review May 8, 2020 15:14
sharding/xorValidatorShuffler_test.go Show resolved Hide resolved
sharding/xorValidatorShuffler.go Outdated Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Outdated Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Show resolved Hide resolved
sharding/validatorDistributor.go Show resolved Hide resolved
sharding/xorValidatorShuffler.go Outdated Show resolved Hide resolved
sharding/xorValidatorShuffler.go Outdated Show resolved Hide resolved
sharding/xorValidatorShuffler.go Outdated Show resolved Hide resolved
sharding/xorValidatorShuffler.go Outdated Show resolved Hide resolved
consensus/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
core/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
integrationTests/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
node/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
process/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Outdated Show resolved Hide resolved
sharding/xorValidatorShuffler.go Outdated Show resolved Hide resolved
sharding/xorValidatorShuffler.go Show resolved Hide resolved
sasurobert
sasurobert previously approved these changes May 8, 2020
AdoAdoAdo
AdoAdoAdo previously approved these changes May 10, 2020
sasurobert
sasurobert previously approved these changes May 11, 2020
AdoAdoAdo
AdoAdoAdo previously approved these changes May 11, 2020
@raduchis raduchis dismissed stale reviews from AdoAdoAdo and sasurobert via d47a01f May 11, 2020 18:34
heartbeat/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
heartbeat/mock/nodesCoordinatorMock.go Outdated Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Outdated Show resolved Hide resolved
sharding/indexHashedNodesCoordinator.go Outdated Show resolved Hide resolved
@LucianMincu LucianMincu self-requested a review May 13, 2020 08:35
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 0c02e3b into development May 13, 2020
@LucianMincu LucianMincu deleted the en-6282-observer-nodes-shuffled-out-fix branch May 13, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants