consensus epoch number fix #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # process/peer/export_test.go
# Conflicts: # process/peer/export_test.go
…m/ElrondNetwork/elrond-go into EN-6511-consensus-epoch-incorrect
…t' into EN-6511-consensus-epoch-incorrect
AdoAdoAdo
previously approved these changes
Jun 1, 2020
| } | ||
|
|
||
| // DecreaseLeaderSuccessRate - | ||
| func (p *PeerAccountHandlerMock) DecreaseLeaderSuccessRate(val uint32) { | ||
| if p.DecreaseLeaderSuccessRateCalled != nil { | ||
| p.DecreaseLeaderSuccessRateCalled(val) | ||
| } | ||
| p.DecreaseLeaderSuccessRateValue += val | ||
| } | ||
|
|
||
| // IncreaseValidatorSuccessRate - | ||
| func (p *PeerAccountHandlerMock) IncreaseValidatorSuccessRate(val uint32) { | ||
| if p.IncreaseValidatorSuccessRateCalled != nil { | ||
| p.IncreaseValidatorSuccessRateCalled(val) |
There was a problem hiding this comment.
Should be added return ?
There was a problem hiding this comment.
yes, no need for the += afterwards
| } | ||
| p.IncreaseLeaderSuccessRateValue += val | ||
| } | ||
|
|
||
| // DecreaseLeaderSuccessRate - | ||
| func (p *PeerAccountHandlerMock) DecreaseLeaderSuccessRate(val uint32) { | ||
| if p.DecreaseLeaderSuccessRateCalled != nil { | ||
| p.DecreaseLeaderSuccessRateCalled(val) |
There was a problem hiding this comment.
Should be added return ?
| } | ||
|
|
||
| // IncreaseValidatorSuccessRate - | ||
| func (p *PeerAccountHandlerMock) IncreaseValidatorSuccessRate(val uint32) { | ||
| if p.IncreaseValidatorSuccessRateCalled != nil { | ||
| p.IncreaseValidatorSuccessRateCalled(val) | ||
| } | ||
| p.IncreaseValidatorSuccessRateValue += val | ||
| } | ||
|
|
||
| // DecreaseValidatorSuccessRate - | ||
| func (p *PeerAccountHandlerMock) DecreaseValidatorSuccessRate(val uint32) { | ||
| if p.DecreaseValidatorSuccessRateCalled != nil { | ||
| p.DecreaseValidatorSuccessRateCalled(val) |
There was a problem hiding this comment.
Should be added return ?
process/peer/process.go
Outdated
| // TODO: change if start of epoch block needs to be validated by the new epoch nodes | ||
| // previous block was proposed by the consensus group of the previous epoch | ||
| epoch := header.GetEpoch() | ||
| if (header.IsStartOfEpochBlock()) && epoch > 0 { |
There was a problem hiding this comment.
No need for open-close ()
process/peer/process.go
Outdated
| if !ok { | ||
| return fmt.Errorf("%w - updateShardDataPeerState header from cache - hash: %s, round: %v, nonce: %v", | ||
| process.ErrMissingHeader, | ||
| hex.EncodeToString(h.GetPrevHash()), |
| @@ -596,6 +598,535 @@ func TestValidatorStatisticsProcessor_UpdatePeerStateCallsIncrease(t *testing.T) | |||
| assert.True(t, increaseValidatorCalled) | |||
| } | |||
|
|
|||
| func TestValidatorStatisticsProcessor_UpdatePeerState_IncreasesConsensusPreviousMetaBlock_SameEpoch(t *testing.T) { | |||
| t.Parallel() | |||
There was a problem hiding this comment.
Add empty line after each t.Parallel() in this file
AdoAdoAdo
previously approved these changes
Jun 1, 2020
AdoAdoAdo
previously approved these changes
Jun 1, 2020
SebastianMarian
previously approved these changes
Jun 1, 2020
raduchis
dismissed stale reviews from SebastianMarian and AdoAdoAdo
The base branch was changed.
AdoAdoAdo
approved these changes
Jun 1, 2020
SebastianMarian
approved these changes
Jun 1, 2020
LucianMincu
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computation of the consensus group for the start of epoch block was computed with the current epoch not the previous epoch