bugFix/account-wrap-is-nil #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mall piece of information - what is the main cause.
data/state/journalEntries.go
Outdated
| @@ -101,7 +103,7 @@ type journalEntryDataTrieUpdates struct { | |||
| // NewJournalEntryDataTrieUpdates outputs a new JournalEntryDataTrieUpdates implementation used to revert an account's data trie | |||
| func NewJournalEntryDataTrieUpdates(trieUpdates map[string][]byte, account baseAccountHandler) (*journalEntryDataTrieUpdates, error) { | |||
| if check.IfNil(account) { | |||
| return nil, ErrNilAccountHandler | |||
| return nil, fmt.Errorf("%w in NewJournalEntryAccount", ErrNilAccountHandler) | |||
There was a problem hiding this comment.
NewJournalEntryDataTrieUpdates
| @@ -165,7 +165,7 @@ func (stp *stakingToPeer) UpdateProtocol(body *block.Body, nonce uint64) error { | |||
| if len(data) == 0 { | |||
| err = stp.peerState.RemoveAccount(blsPubKey) | |||
| if err != nil { | |||
| return err | |||
| log.Debug("staking to protocol RemoveAccount error", "err", err, "blsPubKey", blsPubKey) | |||
There was a problem hiding this comment.
log.Error ? and "staking to protocol RemoveAccount failed" to avoid displaying twice "error" and "err"
There was a problem hiding this comment.
I will put to log.logiferror.
| @@ -258,7 +258,7 @@ func (sc *scProcessor) ExecuteSmartContractTransaction( | |||
| var results []data.TransactionHandler | |||
| results, consumedFee, err = sc.processVMOutput(vmOutput, txHash, tx, acntSnd, vmInput.CallType) | |||
| if err != nil { | |||
| log.Trace("process vm output error", "error", err.Error()) | |||
| log.Trace("process vm output returned with problem ", "err", err.Error()) | |||
There was a problem hiding this comment.
Should be log.Debug ? and "process vm output failed" ?
There was a problem hiding this comment.
no need. for any sc fail you would get a lot of messages. which are not needed.
vm/systemSmartContracts/auction.go
Outdated
| @@ -471,7 +467,7 @@ func (s *stakingAuctionSC) registerBLSKeys( | |||
| ) ([][]byte, error) { | |||
| maxNodesToRun := big.NewInt(0).SetBytes(args[0]).Uint64() | |||
| if uint64(len(args)) < maxNodesToRun+1 { | |||
| log.Debug("not enough arguments to process stake function") | |||
| s.eei.AddReturnMessage("not enough arguments to process stake function") | |||
There was a problem hiding this comment.
We can use the same pattern used in this file:
s.eei.AddReturnMessage(fmt.Sprintf("not enough arguments to process stake function: expected min %d, got %d", maxNodesToRun+1, len(args)))
raduchis
requested changes
Jun 1, 2020
SebastianMarian
approved these changes
Jun 1, 2020
raduchis
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the error is from stakingToPeer RemoveAccount call. Still missing a small piece of information - what is the main cause.