Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus dependent antiflood parameters #1839

Merged

Conversation

iulianpascalau
Copy link
Contributor

  • added flood preventer adapting values capability against consensus size

@iulianpascalau iulianpascalau self-assigned this Jun 1, 2020
@sasurobert sasurobert self-requested a review June 1, 2020 13:28
sasurobert
sasurobert previously approved these changes Jun 1, 2020
basePeerMaxMessagesPerInterval := mainConfig.Antiflood.PeerMaxOutput.BaseMessagesPerInterval
peerMaxTotalSizePerInterval := mainConfig.Antiflood.PeerMaxOutput.TotalSizePerInterval
arg := floodPreventers.ArgQuotaFloodPreventer{
Name: "output",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@raduchis raduchis self-requested a review June 1, 2020 14:11
raduchis
raduchis previously approved these changes Jun 1, 2020
@iulianpascalau iulianpascalau dismissed stale reviews from raduchis and sasurobert via ef4ddce June 1, 2020 15:41
raduchis
raduchis previously approved these changes Jun 1, 2020
sasurobert
sasurobert previously approved these changes Jun 1, 2020
@iulianpascalau iulianpascalau dismissed stale reviews from sasurobert and raduchis via 1fccd63 June 1, 2020 19:05
@iulianpascalau iulianpascalau force-pushed the consensus-dependent-antiflood-parameters branch from ade7f73 to ef4ddce Compare June 1, 2020 20:41
iulianpascalau and others added 3 commits June 1, 2020 23:41
…arameters

# Conflicts:
#	process/throttle/antiflood/floodPreventers/quotaFloodPreventer.go
#	process/throttle/antiflood/floodPreventers/quotaFloodPreventer_test.go
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

@LucianMincu LucianMincu merged commit 28c3858 into release-candidate Jun 1, 2020
@LucianMincu LucianMincu deleted the consensus-dependent-antiflood-parameters branch June 1, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants