bug fix get transaction api route #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
approved these changes
Jun 5, 2020
sasurobert
approved these changes
Jun 5, 2020
andreibancioiu
approved these changes
Jun 5, 2020
| @@ -500,17 +502,42 @@ func TestNode_GetTransaction_ShouldNotFindAndReturnUnknown(t *testing.T) { | |||
| assert.Error(t, err) | |||
| } | |||
|
|
|||
| func getCacherHandler(find bool) func() dataRetriever.ShardedDataCacherNotifier { | |||
| func getCacherHandler(find bool, cacherType string) func() dataRetriever.ShardedDataCacherNotifier { | |||
There was a problem hiding this comment.
You could have created separate functions to create the dummy pools (without the switch). But ok for now.
LucianMincu
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic bug when try to get a transaction which is in pool using api route /transaction/:txhash
Bug: In pool transactions are kept as objects ( Transaction, RewardTransaction, SmartContracResult, etc..) and when you try to get a transaction from pool there was a wrong cast to []byte which panics.
Fix: Removed the wrong cast and added a new function which do a cast to a specific transaction.