crypto: benchmark BLS single signing and verification #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arm64 Rasp Pi 4 |
iulianpascalau
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
On an i3 - gen3 2 cores, 4 logical CPUs I've got:
BenchmarkBlsSingleSigner_Sign - 456.536 uS/op
BenchmarkBlsSingleSigner_Verify - 2.327 ms/op
On an i5 - gen4 2 cores, 4 logical CPUs I've got:
BenchmarkBlsSingleSigner_Sign - 445.511 uS/op
BenchmarkBlsSingleSigner_Verify - 2.255 ms/op
andreibancioiu
approved these changes
Jun 8, 2020
|
|
||
| var err error | ||
| nbMessages := 10000 | ||
| messages := make([][]byte, 0, 10000) |
There was a problem hiding this comment.
Could have used nbMessages.
|
|
||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| _, err = signer.Sign(privKey, messages[i%nbMessages]) |
There was a problem hiding this comment.
Messages to sign are quite short. Maybe relevant to the benchmark?
|
|
||
| var err error | ||
| nbMessages := 10000 | ||
| messages := make([][]byte, 0, 10000) |
There was a problem hiding this comment.
Could have used nbMessages.
|
|
||
| b.ResetTimer() | ||
| for i := 0; i < b.N; i++ { | ||
| err = signer.Verify(pubKey, messages[i%nbMessages], signatures[i%nbMessages]) |
There was a problem hiding this comment.
Messages to verify are a bit short (see above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go test crypto/signing/mcl/singlesig/bls_bench_test.go -bench BlsSingleSigner
i7 7th gen
BenchmarkBlsSingleSigner_Sign-4 3208 401445 ns/op
BenchmarkBlsSingleSigner_Verify-4 870 1628854 ns/op