En 6312/meta tx standard #1885
Merged
En 6312/meta tx standard #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # epochStart/bootstrap/process_test.go
… of hex character - fixed genesis package
…etwork/elrond-go into EN-6312/Meta-tx-standard
…N-6312/Meta-tx-standard
# Conflicts: # cmd/node/main.go # epochStart/bootstrap/common.go # epochStart/bootstrap/process.go # epochStart/bootstrap/process_test.go # integrationTests/multiShard/endOfEpoch/startInEpoch/startInEpoch_test.go
… tx value should go back to relayer.
…o relayer - the difference should go back to sender.
…o relayer - the difference should go back to sender.
| @@ -18,8 +20,11 @@ github.com/ElrondNetwork/elrond-vm-common v0.0.0-20191203115206-691b00a6e76a/go. | |||
| github.com/ElrondNetwork/elrond-vm-common v0.1.9/go.mod h1:ZakxPST/Wt8umnRtA9gobcy3Dw2bywxwkC54P5VhO9g= | |||
| github.com/ElrondNetwork/elrond-vm-common v0.1.19 h1:mRO768HtMyXY23pvG18DonKVEIlNvXxoyKP94S9fb2A= | |||
| github.com/ElrondNetwork/elrond-vm-common v0.1.19/go.mod h1:ZakxPST/Wt8umnRtA9gobcy3Dw2bywxwkC54P5VhO9g= | |||
| @@ -279,7 +285,7 @@ func (sc *scProcessor) ExecuteSmartContractTransaction( | |||
| acntDst, err = sc.reloadLocalAccount(acntDst) | |||
| if err != nil { | |||
| log.Debug("reloadLocalAccount error", "error", err.Error()) | |||
| return nil | |||
| return 0, err | |||
There was a problem hiding this comment.
Does this value has a constant? Maybe move to a (new) const.
There was a problem hiding this comment.
when critical error is returned the return code is not used, like sending nil back when critical error
| @@ -137,6 +148,55 @@ func (inTx *InterceptedTransaction) CheckValidity() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (inTx *InterceptedTransaction) verifyIfRelayedTx(tx *transaction.Transaction) error { | |||
There was a problem hiding this comment.
Tests missing for this function
There was a problem hiding this comment.
agreed after first reviews will do it. may merge after disabling this txtype
| @@ -393,6 +409,229 @@ func (txProc *txProcessor) moveBalances( | |||
| return nil | |||
| } | |||
|
|
|||
| func (txProc *txProcessor) processRelayedTx( | |||
There was a problem hiding this comment.
This needs heavy testing
There was a problem hiding this comment.
agreed after first reviews will do it. may merge after disabling.
| @@ -414,6 +414,9 @@ const BuiltInFunctionSaveKeyValue = "SaveKeyValue" | |||
| // BuiltInFunctionESDTTransfer is the key for the elrond standard digital token transfer built-in function | |||
| const BuiltInFunctionESDTTransfer = "ESDTTransfer" | |||
|
|
|||
| // RelayedTransaction is the key for the elrond meta/gassless/relayed transaction standard | |||
| const RelayedTransaction = "relayedTx" | |||
There was a problem hiding this comment.
Please rename the document (the title) to use this term instead of "meta".
process/errors.go
Outdated
| var ErrRecursiveRelayedTXIsNotAllowed = errors.New("recursive relayed tx is not allowed") | ||
|
|
||
| // ErrRelayedTxValueHigherThenUserTxValue signals that relayed tx value is higher then user tx value | ||
| var ErrRelayedTxValueHigherThenUserTxValue = errors.New("relayed tx value is higher then user tx value") |
process/errors.go
Outdated
| var ErrInvalidVMType = errors.New("invalid VM type") | ||
|
|
||
| // ErrRecursiveRelayedTXIsNotAllowed signals that recursive relayed tx is not allowed | ||
| var ErrRecursiveRelayedTXIsNotAllowed = errors.New("recursive relayed tx is not allowed") |
There was a problem hiding this comment.
Typo / case of "TX" vs. "Tx" below.
sasurobert
changed the base branch from
feat/new-development
to
feat/new-features
iulianpascalau
approved these changes
Jun 15, 2020
andreibancioiu
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented meta transaction standard.
Attached documentation: https://docs.google.com/document/d/1P-ZNs2BCvHheb9jAkVC6MYWsWfGoQzAHbvBnrvezXAQ/edit