EN-6710 antiflood blocks consensus fix #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jun 9, 2020
•
iulianpascalau
commented
- changed peerMaxMessagesPerSec to 5 in order to avoid consensus topic being block by the topic flood preventer component
- tweaked antiflood parameters
- added sequence number in antiflood debug lines
sasurobert
previously approved these changes
Jun 9, 2020
bogdan-rosianu
previously approved these changes
Jun 9, 2020
- printed sequence numbers in antiflood debug
…om/ElrondNetwork/elrond-go into EN-6710-antiflood-blocks-consensus
iulianpascalau
dismissed stale reviews from bogdan-rosianu and sasurobert
via
f10e19e
sasurobert
previously approved these changes
Jun 9, 2020
sasurobert
approved these changes
Jun 9, 2020
andreibancioiu
approved these changes
Jun 9, 2020
| @@ -5,7 +5,17 @@ import ( | |||
| "github.com/ElrondNetwork/elrond-go/consensus/spos" | |||
| ) | |||
|
|
|||
| const peerMaxMessagesPerSec = uint32(2) | |||
| // peerMaxMessagesPerSec defines how many messages can be propagated by a pid in a round. The value was chosen by | |||
LucianMincu
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.