bugFix/rewards-missmatch-computation #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epochStart/metachain/rewards.go
Outdated
| ValidatorFailure uint32 | ||
| NumSelectedInSuccessBlocks uint32 | ||
| AccumulatedFees *big.Int | ||
| numSelectedInSuccessBlocks uint32 |
There was a problem hiding this comment.
tought I deleted all.
ccorcoveanu
reviewed
Jun 10, 2020
| @@ -121,6 +118,7 @@ func NewEpochStartRewardsCreator(args ArgsNewRewardsCreator) (*rewardsCreator, e | |||
|
|
|||
| // CreateBlockStarted announces block creation started and cleans inside data | |||
| func (rc *rewardsCreator) clean() { | |||
| rc.mapRewardsPerBlockPerValidator = make(map[uint32]*big.Int) | |||
There was a problem hiding this comment.
Should you do the same in the constructor so it won't be nil?
There was a problem hiding this comment.
no need clean is called every time CreateRewards is called.
ccorcoveanu
approved these changes
Jun 10, 2020
SebastianMarian
approved these changes
Jun 10, 2020
LucianMincu
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the wrong computation of end of epoch rewards. In case the same validator had multiple nodes in multiple shards the actual reward was calculated with NumTotalSelected divided by the last shardID set for this validator. The last shard ID set was from range over a map.