Get transaction with status api route #1969
Conversation
miiu96
changed the title
node/nodeTransactions.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func (n *Node) computeTransactionStatus(tx data.TransactionHandler, isInPool bool) string { |
There was a problem hiding this comment.
We can return TransactionStatus here, and perhaps also use this type for the new tx field - and let the marshelizer do its job (optional - and hopefully it will work).
There was a problem hiding this comment.
json marshaler will be happy with that.
There was a problem hiding this comment.
yes maybe json marshalizer will be happy with that but if we change core.TransactionStatus in a more complex structure that contains more than a single 'string' field will not work anymore. if you strongly suggest that ,i will change... wait for your answer.
node/nodeTransactions.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func (n *Node) computeTransactionStatus(tx data.TransactionHandler, isInPool bool) string { |
There was a problem hiding this comment.
json marshaler will be happy with that.
node/nodeTransactions_test.go
Outdated
| @@ -294,6 +296,97 @@ func TestNode_GetTransaction_ShouldNotFindAndReturnUnknown(t *testing.T) { | |||
| assert.Error(t, err) | |||
| } | |||
|
|
|||
| func TestNode_ComputeTransactionStatusAllBranches(t *testing.T) { | |||
There was a problem hiding this comment.
Can remove the suffix "AllBranches" perhaps.
node/nodeTransactions_test.go
Outdated
| rwdTxCrossShard := &rewardTx.RewardTx{RcvAddr: shardZeroAddr} | ||
| normalTxIntraShard := &transaction.Transaction{RcvAddr: shardZeroAddr, SndAddr: shardZeroAddr} | ||
| normalTxCrossShard := &transaction.Transaction{RcvAddr: shardOneAddr, SndAddr: shardZeroAddr} | ||
| unsignedTxIntraShard := &smartContractResult.SmartContractResult{RcvAddr: shardOneAddr, SndAddr: shardZeroAddr} |
There was a problem hiding this comment.
This one is cross shard. Also add another one for intra-shard :)
| txStatus = n.ComputeTransactionStatus(unsignedTxIntraShard, true) | ||
| assert.Equal(t, core.TxStatusReceived, txStatus) | ||
|
|
||
| // cross shard scr in storage source shard |
There was a problem hiding this comment.
Cross-shard, on destination, for rewards - not covered. But the test is sufficient though.
There was a problem hiding this comment.
yeah i think is sufficient because all branches are covered.
Removed api route
/transaction/:hash/statusbecause a single observer cannot provided a correct status of a transaction (the case when a transaction is cross shard)Modified api route
/transaction/:hashto return also transaction status from view of a obsever (is not 100% correct because an observer from shard 0 cannot know what is the status of a transaction from shard 1). Processing of a correct status of a transaction will be done on proxy application.