EN 6803 close arwen after genesis #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jun 17, 2020
iulianpascalau
commented
- closed vm container to close the arwen process
- switched to new logger version
- main closing wait will be done only if the components could not be gracefully closed
- switched to new logger version - main closing wait will be done only if the components could not be gracefully closed
sasurobert
reviewed
Jun 17, 2020
cmd/node/main.go
Outdated
| select { | ||
| case <-chanCloseComponents: | ||
| case <-time.After(maxTimeToClose): | ||
| log.Debug("closeAllComponents did not finished on time, force closing the node") |
There was a problem hiding this comment.
log.Warn / error maybe ?
There was a problem hiding this comment.
add error in the message in order to find it easily.
| @@ -12,6 +12,8 @@ github.com/ElrondNetwork/concurrent-map v0.1.2/go.mod h1:3XwSwn4JHI0lrKxWLZvtp53 | |||
| github.com/ElrondNetwork/elrond-go-logger v1.0.2/go.mod h1:e5D+c97lKUfFdAzFX7rrI2Igl/z4Y0RkKYKWyzprTGk= | |||
| github.com/ElrondNetwork/elrond-go-logger v1.0.3 h1:PHH6m0vhgBbChd8Cu3Oda5LS1FtPcQRQw8DGM5osZ3Y= | |||
| github.com/ElrondNetwork/elrond-go-logger v1.0.3/go.mod h1:e5D+c97lKUfFdAzFX7rrI2Igl/z4Y0RkKYKWyzprTGk= | |||
| github.com/ElrondNetwork/elrond-go-logger v1.0.4 h1:i5Yu4qyjTZDwvBY/ykbNpp2SP9jxwk/QTivRwSZSTAQ= | |||
andreibancioiu
previously approved these changes
Jun 17, 2020
- changed the log error message when closeAllComponents failed to finish
andreibancioiu
approved these changes
Jun 17, 2020
sasurobert
approved these changes
Jun 17, 2020
LucianMincu
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.