EN 6813 p2p debugger #1978
Merged
EN 6813 p2p debugger #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk/elrond-go into EN-6813-p2p-debugger
sasurobert
requested changes
Jun 18, 2020
debug/p2p/p2pDebugger.go
Outdated
|
|
||
| var log = logger.GetOrCreate("debug/p2p") | ||
|
|
||
| const printTimeOneSecond = time.Second //if this needs to be changed, remember to divide the values when computing metrics |
There was a problem hiding this comment.
add a const for X * time.second - use X for division :)
There was a problem hiding this comment.
should have never wrote that comment :))))
debug/p2p/p2pDebugger.go
Outdated
| return pd | ||
| } | ||
|
|
||
| func (pd *p2pDebugger) checkLogTrace() bool { |
| mut sync.Mutex | ||
| data map[string]*metric | ||
| cancelFunc func() | ||
| shouldProcessDataFn func() bool |
There was a problem hiding this comment.
no need for these 2 function pointers - shouldProcessDataFn and printStringFn
There was a problem hiding this comment.
I need them to properly test this struct
debug/p2p/p2pDebugger.go
Outdated
| } | ||
| } | ||
|
|
||
| func (pd *p2pDebugger) doStatsString() string { |
There was a problem hiding this comment.
statsToString
debug/p2p/p2pDebugger.go
Outdated
| return m | ||
| } | ||
|
|
||
| func (pd *p2pDebugger) doStats(ctx context.Context) { |
There was a problem hiding this comment.
continuouslyPrintStatistics
| @@ -277,3 +277,10 @@ type Cacher interface { | |||
| HasOrAdd(key []byte, value interface{}, sizeInBytes int) (ok, evicted bool) | |||
| IsInterfaceNil() bool | |||
| } | |||
|
|
|||
| type Debugger interface { | |||
There was a problem hiding this comment.
comment to public interface
AdoAdoAdo
requested review from
AdoAdoAdo and
BeniaminDrasovean
and removed request for
AdoAdoAdo
BeniaminDrasovean
previously approved these changes
Jun 19, 2020
BeniaminDrasovean
approved these changes
Jun 19, 2020
sasurobert
approved these changes
Jun 19, 2020
LucianMincu
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable it, run the node with
*:INFO,debug/p2p:TRACE