Add feedback for peer honesty in consensus #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Jun 18, 2020
SebastianMarian
commented
- Added a consensus rating mechanism to handle the situation when some peers would flood the consensus topic with invalid messages
- Fixed an uncovered situation in which a blacklist should be applied for both, originator and the connected peer, if an invalid message would be received on consensus topic
…e peers would flood the consensus topic with invalid messages * Fixed an uncovered situation in which a blacklist should be applied for both, originator and the connected peer, if an invalid message would be received on consensus topic
sasurobert
requested changes
Jun 18, 2020
consensus/spos/bls/subroundBlock.go
Outdated
| @@ -589,3 +559,21 @@ func (sr *subroundBlock) getRoundInLastCommittedBlock() int64 { | |||
|
|
|||
| return roundInLastCommittedBlock | |||
| } | |||
|
|
|||
| func (sr *subroundBlock) updateLeaderPeerHonesty(node string) { | |||
There was a problem hiding this comment.
Duplicate code with subroundEndRound. Suggestion to move this in Subround struct.
| @@ -279,3 +269,21 @@ func (sr *subroundSignature) remainingTime() time.Duration { | |||
|
|
|||
| return remainigTime | |||
| } | |||
|
|
|||
| func (sr *subroundSignature) updateValidatorPeerHonesty(node string) { | |||
There was a problem hiding this comment.
This can also be moved in Subround struct
iulianpascalau
previously approved these changes
Jun 19, 2020
sasurobert
previously approved these changes
Jun 19, 2020
* Refactored Increase adn Decrease mechanism * Fixed a blcklisted situation which should not be done
SebastianMarian
dismissed stale reviews from sasurobert and iulianpascalau
via
aabbad1
iulianpascalau
previously approved these changes
Jun 21, 2020
…huffling out state (self shard ID could be reported differently for a while, max. 25% from an epoch time, by shard coordinator and by nodes coordinator)
…-consensus' into add-feedback-for-peer-honesty-in-consensus
iulianpascalau
previously approved these changes
Jun 21, 2020
…ocess on time the epoch start block
…-consensus' into add-feedback-for-peer-honesty-in-consensus
sasurobert
approved these changes
Jun 22, 2020
LucianMincu
approved these changes
Jun 22, 2020
iulianpascalau
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.