Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune state only behind finalized #1988

Merged
merged 5 commits into from Jun 24, 2020
Merged

Prune state only behind finalized #1988

merged 5 commits into from Jun 24, 2020

Conversation

BeniaminDrasovean
Copy link
Contributor

Prune state only behind final header that is also committed by self.

@BeniaminDrasovean BeniaminDrasovean added the type:bug Something isn't working label Jun 22, 2020
@BeniaminDrasovean BeniaminDrasovean self-assigned this Jun 22, 2020
@BeniaminDrasovean BeniaminDrasovean changed the title prune state only behind finalized Prune state only behind finalized Jun 22, 2020
sasurobert
sasurobert previously approved these changes Jun 22, 2020
View reviewed changes
LucianMincu
LucianMincu previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests passed.

LucianMincu
LucianMincu approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@LucianMincu LucianMincu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iulianpascalau iulianpascalau merged commit 770d618 into release-candidate Jun 24, 2020
@iulianpascalau iulianpascalau deleted the prune-state-behind-final-bug branch June 24, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasurobert sasurobert sasurobert approved these changes

@LucianMincu LucianMincu LucianMincu approved these changes

@iulianpascalau iulianpascalau iulianpascalau approved these changes

@SebastianMarian SebastianMarian SebastianMarian approved these changes

Assignees

@BeniaminDrasovean BeniaminDrasovean

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BeniaminDrasovean @sasurobert @LucianMincu @iulianpascalau @SebastianMarian