Add new deny peer cache #1992
Merged
Add new deny peer cache #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iulianpascalau
commented
Jun 22, 2020
iulianpascalau
commented
- added a peer denial evaluator able to track black listed public keys beside peer IDs
…s beside peer IDs
sasurobert
requested changes
Jun 23, 2020
| // IsDenied returns true if the provided peer id is denied to access the network | ||
| // It also checks if the provided peer id has a backing public key, checking also that the public key is not denied | ||
| func (pde *peerDenialEvaluator) IsDenied(pid core.PeerID) bool { | ||
| if pde.peerIdsCache.Has(pid) { |
There was a problem hiding this comment.
rename to blakcListIDsCache
| return false //no need to further search in the next cache, this is an unknown peer | ||
| } | ||
|
|
||
| return pde.publicKeysCache.Has(string(pkBytes)) |
There was a problem hiding this comment.
rename to blakcListedPublicKeysCache
AdoAdoAdo
previously approved these changes
Jun 23, 2020
# Conflicts: # factory/networkComponents.go # process/interceptors/processor/hdrInterceptorProcessor.go # update/errors.go
sasurobert
approved these changes
Jun 23, 2020
AdoAdoAdo
approved these changes
Jun 23, 2020
LucianMincu
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.