Bug fixes elastic search indexer #1997
Conversation
| if err != nil { | ||
| log.Warn("indexer: response body", | ||
| "body", string(responseBody)) | ||
| log.Warn("indexer:cannot read from response body", "error", err) |
| @@ -104,16 +104,16 @@ func (ei *elasticIndexer) SaveBlock( | |||
| } | |||
|
|
|||
| txsSizeInBytes := computeSizeOfTxs(ei.marshalizer, txPool) | |||
| go ei.database.SaveHeader(headerHandler, signersIndexes, body, notarizedHeadersHashes, txsSizeInBytes) | |||
| ei.database.SaveHeader(headerHandler, signersIndexes, body, notarizedHeadersHashes, txsSizeInBytes) | |||
There was a problem hiding this comment.
may be leave to go routines - add a go routine throttler ?
There was a problem hiding this comment.
for the moment i will let as it is because method SaveBlock is called on a goroutine and i want the writing of header, miniblocks and transaction to be serial because this write do a lot of requests to elasticsearch database because have to check if miniblocks and transactions exits in database.
miiu96
changed the title
| var responseBody []byte | ||
| responseBody, err = ioutil.ReadAll(res.Body) | ||
| if err != nil { | ||
| log.Warn("indexer: response body", |
There was a problem hiding this comment.
You should delete this Warn, as responeBody should be nil if err != nil. Did you want to log res.Body? If you want to keep this warn you can add it in the next warn as additional info:
log.Warn("indexer:cannot read from response body", "body", string(responseBody), "error", err)
| var decodedBody object | ||
| if err := json.NewDecoder(res.Body).Decode(&decodedBody); err != nil { | ||
| if err := json.Unmarshal(responseBody, &decodedBody); err != nil { | ||
| log.Warn("indexer: response body", |
There was a problem hiding this comment.
Delete this warn and add it in the next Warn as additional info, like suggested above
| txsPool[hashes[i]] = &txs[i] | ||
| } | ||
| for i := 0; i < 1000; i++ { | ||
| numTransactions := 1 |
There was a problem hiding this comment.
Move these two lines outside the for
| } | ||
| header := &dataBlock.Header{} | ||
| txsPool := make(map[string]data.TransactionHandler) | ||
| for i := 0; i < numTransactions; i++ { |
There was a problem hiding this comment.
Use j instead i. The outer for uses also i for iteration
| TxHashes: make([][]byte, numTransactions), | ||
| Type: dataBlock.TxBlock, | ||
| } | ||
| for i := 0; i < numTransactions; i++ { |
There was a problem hiding this comment.
Use j instead i. The outer for uses also i for iteration
No description provided.