Fix block size throttle #1999
Merged
Fix block size throttle #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SebastianMarian
commented
Jun 23, 2020
•
SebastianMarian
commented
- Optimized mutex Lock/Unlock in txsPoolsCleaner component
- Tweaked some parameters in createAndProcessCrossMiniBlocksDstMe (how many shard/meta headers could be included in one block)
- Reduced number of go routines from 2000 to 100
- Tweaked some parameters in blockSizeThrottle component to speed up adaptivity to the network conditions
- Fixed a situation when block max size, from blockSizeThrottle component, is increased to slow after a network problem
* Tweaked some parameters in createAndProcessCrossMiniBlocksDstMe (how many shard/meta headers should be included in one block) * Reduced number of go routines from 2000 to 100 * Tweaked some parameters in blockSizeThrottle component to speed up adaptivity to the network conditions * Fixed a situation when block max size, from blockSizeThrottle component, is increased to slow after a network problem
sasurobert
approved these changes
Jun 23, 2020
andreibancioiu
approved these changes
Jun 23, 2020
| @@ -18,7 +18,7 @@ import ( | |||
| "github.com/ElrondNetwork/elrond-go/sharding" | |||
| ) | |||
|
|
|||
| const numGoRoutines = 2000 | |||
| const numGoRoutines = 100 | |||
There was a problem hiding this comment.
Dramatic decrease :)
There was a problem hiding this comment.
Yep, this was the suggested value by @iulianpascalau
| @@ -178,10 +178,11 @@ func (tpc *txsPoolsCleaner) processReceivedTx( | |||
| receiverShardID uint32, | |||
| txType int8, | |||
| ) { | |||
| tpc.mutMapTxsRounds.Lock() | |||
| defer tpc.mutMapTxsRounds.Unlock() | |||
| tpc.mutMapTxsRounds.RLock() | |||
There was a problem hiding this comment.
Now I see that the cleaner removes each tx individually, it doesn't call the bulk operations (e.g. RemoveSetOfDataFromPool) but that should be fine nonetheless.
There was a problem hiding this comment.
Yes, because we don't have such a method implemented, but anyway the cleanTxsPoolsIfNeeded method is ran only once per minute.
LucianMincu
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.