Unit tests governance smart contract #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
requested changes
Jun 24, 2020
| @@ -124,8 +125,7 @@ func (g *governanceContract) init(args *vmcommon.ContractCallInput) vmcommon.Ret | |||
|
|
|||
| g.eei.SetStorage([]byte(governanceConfigKey), marshaledData) | |||
| g.eei.SetStorage([]byte(ownerKey), args.CallerAddr) | |||
| g.ownerAddress = make([]byte, 0, len(args.CallerAddr)) | |||
| g.ownerAddress = append(g.ownerAddress, args.CallerAddr...) | |||
| g.ownerAddress = args.CallerAddr | |||
There was a problem hiding this comment.
leave with complete copy.
|
|
||
| retCode := gsc.Execute(callInput) | ||
| require.Equal(t, vmcommon.Ok, retCode) | ||
| } |
There was a problem hiding this comment.
we need another test -> create a general proposal - add multiple voting transactions and one transaction to finalize it. Check in the end the ProposalStatus. This should be done without mocks. For example look in test: TestStakingAuctionSC_ExecuteStakeUnStakeOneBlsPubKeyAndRestake
SebastianMarian
previously approved these changes
Jun 24, 2020
miiu96
changed the title
sasurobert
requested changes
Jun 25, 2020
vm/mock/auctionSCMock.go
Outdated
| import vmcommon "github.com/ElrondNetwork/elrond-vm-common" | ||
|
|
||
| // AuctionSCMock - | ||
| type AuctionSCMock struct { |
There was a problem hiding this comment.
this is systemSCstub - as it implements the systemSCinterface
There was a problem hiding this comment.
and you already have SystemSCStub in the mock folder
| // 3. WhileList a new address, vote with 2 validators with yes and close white list proposal | ||
| // 4. Create a new general proposal with new white listed address, vote with 2 validator with yes general proposal | ||
| // and close proposal | ||
| func TestGovernanceContract_ExecuteProposalCloseProposal(t *testing.T) { |
There was a problem hiding this comment.
you might add a function for each step 1, 2, 3 and 4
sasurobert
approved these changes
Jun 26, 2020
SebastianMarian
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a lot of unit tests for governance system smart contract also did some fixes in the contract.a