En 6833/antiflood observers #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
requested changes
Jun 24, 2020
| @@ -156,6 +165,10 @@ func (mdi *MultiDataInterceptor) ProcessReceivedMessage(message p2p.MessageP2P, | |||
| ) | |||
| } | |||
|
|
|||
| if !allWhiteListed && errOriginator != nil { | |||
| log.Debug("got message from peer on topic only for validators", "originator", message.Peer(), "topic", mdi.topic, "err", err) | |||
There was a problem hiding this comment.
This should be changed to:
log.Debug("got message from peer on topic only for validators",
"originator", p2p.PeerIdToShortString(message.Peer()),
"topic", mdi.topic,
"err", err)as message.Peer() might contain unprintable characters
I think we should add a String() function on core.PeerID struct
| isWhiteListed := sdi.whiteListRequested.IsWhiteListed(interceptedData) | ||
| if !isWhiteListed && errOriginator != nil { | ||
| log.Debug("got message from peer on topic only for validators", "originator", message.Peer(), "topic", sdi.topic, "err", err) |
There was a problem hiding this comment.
same here, please use p2p.PeerIdToShortString function
iulianpascalau
previously approved these changes
Jun 24, 2020
|
|
||
| import "github.com/ElrondNetwork/elrond-go/core" | ||
|
|
||
| type PeerValidatorMapper struct { |
There was a problem hiding this comment.
Add a mocked comment
| return process.ErrOnlyValidatorsCanUseThisTopic | ||
| } | ||
|
|
||
| // SetTopicsForAll set the topics which are enabled for all |
iulianpascalau
previously approved these changes
Jun 24, 2020
SebastianMarian
previously approved these changes
Jun 24, 2020
# Conflicts: # process/throttle/antiflood/p2pAntiflood.go
sasurobert
dismissed stale reviews from SebastianMarian and iulianpascalau
via
3377cfe
SebastianMarian
previously approved these changes
Jun 25, 2020
iulianpascalau
previously approved these changes
Jun 25, 2020
sasurobert
dismissed stale reviews from iulianpascalau and SebastianMarian
via
045cc00
| } | ||
|
|
||
| sort.Slice(epochList, func(i, j int) bool { | ||
| return epochList[i] < epochList[j] |
There was a problem hiding this comment.
👍 that should overwrite the values from previous epochs, if the node is performing well.
There was a problem hiding this comment.
That was the idea
| @@ -132,11 +134,7 @@ func (psm *PeerShardMapper) getPeerInfoWithNodesCoordinator(pid core.PeerID) (*c | |||
| }, false | |||
| } | |||
|
|
|||
| psm.mutEpoch.RLock() | |||
There was a problem hiding this comment.
Maybe remove the mutex, epoch and the associated handlers?
There was a problem hiding this comment.
I left there if later it would be used
There was a problem hiding this comment.
later means never :)))
iulianpascalau
previously approved these changes
Jun 26, 2020
SebastianMarian
previously approved these changes
Jun 26, 2020
…de the checking of nonce or epoch start in the case of shard/meta headers.
Fix whitelisting of nonce/epoch requests
sasurobert
dismissed stale reviews from SebastianMarian and iulianpascalau
via
a058e7d
# Conflicts: # process/errors.go
iulianpascalau
approved these changes
Jun 26, 2020
SebastianMarian
approved these changes
Jun 26, 2020
LucianMincu
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not accept messages - do not propagate messages whose originator is not a validator.
Accepted topics are only transactions_selfID and heartbeat